Dungeon Loot Modification - Proposed Fix/Tweak

I definitely see the issue with dungeons getting looted and there being nothing available for new players to explore. I think it's awesome that new players will be able to also get loot again from the same dungeons/chests, so I definitely applaud the direction of the new change and the work that was put in. That said, one of the principals of EMC that I've always admired is the play-your-way style of thinking and keeping things vanilla, and I don't want to lose this. It's really amazing that a player could randomly go out in the waste and play/mine with a vanilla experience.

One main impact I can think of is for the vanilla feel of looting and raiding dungeons. It's common practice for many players exploring mineshafts and dungeons just to destroy the encountered chests. This is a lot faster for collecting the materials, and many would consider it a lot more fun. Again, I consider this to be a personal play style, and a fun vanilla experience, and I think it should be preserved. Opening the chest and manually pulling out items one by one is not nearly as much fun as breaking it and collecting the spoils, and being unable to break the chest greatly disturbs the vanilla feel.

I know the waste is not primarily for building, however many players do build temporary creations intended to help harvest resources such as a mine, quarry, or mob grinder. Imagine that one of these structures happens to be built in the same location as an existing dungeon chest. In the case of a mob grinder this is unavoidable. In other cases, the player may simply not know about the dungeon when they start building. Imagine having to modify your mob grinder design to accommodate a couple random chests, a quarry with random floating chests in the middle, or having to rebuild a whole mine shaft because it happened to hit a dungeon on the way to bedrock. Not only is this an inconvenience to the building player, but griefing is now in many cases required to get the dungeon loot. In the quarry example, another player would have to build an ugly dirt/cobble bridge to get at the chests (which I believe is technically griefing). In the mob grinder example, the chests are pointless because they will be completely hidden, may appear to be another player's stuff, and any attempt to get them would be clearly griefing the mob grinder.

Therefore, while the hood is open, I propose an addition/tweak to the new algorithm which retains all the current benefits while resolving the above issues to maintain a vanilla and play-your-way experience for all EMCers.

1) Dungeon chests can be broken. When a dungeon chest is broken, the same 3-7 day timer is set up on that dungeon chest.

2) After the 3-7 day timer is expired, and a new player enters the chunk you would call an algorithm as in my pseudocode below with the location of the chest passed in as a parameter. This would recreate the chest at the same or a nearby valid location. Among other criteria, my algorithm ensures that the chest is placed above a solid block and has a reasonable amount of air around it. The location of the chest would be updated, or it would be removed if there was no possible location in a 9x9 area (very unlikely to happen). This could be done at any point, such as when the chunk which used to contain the chest is loaded.

3) When that chest is opened, the same 'new player' algorithm applies to populate it with items.

The algorithm searches for a location which must be air and above a solid block. At least two of the 4 directly adjacent locations with the same y must be air. It will search in cubes starting with 1x1 which is where the chest is located, then 3x3, 5x5, 7x7, and finally 9x9. It will favour closer locations, especially on the same y. The chest is then placed, facing a random direction which is not a wall.

Code:

validLocation (x, y, z) {
  //Ensure the location is clear (this location is air).
  if (!is_air(x, y, z)) return false;
  //Ensure no floating chests (the block below is solid).
  if (!is_solid(x, y-1, z)) return false;
  //Ensure chest can be accessed reasonably (at least 2/4 adjacent locations are air).
  count = 0;
  if (is_air(x+1,y+1,z)) count ++;
  if (is_air(x+1,y-1,z)) count ++;
  if (is_air(x-1,y+1,z)) count ++;
  if (is_air(x-1,y-1,z)) count ++;
  if (count >= 2) return true;
  else return false;
}

facesSolid (x, y, z, facing) {
  switch (facing) {
    case west: return is_solid(x-1, y, z);
    case east: return is_solid(x+1, y, z);
    case north: return is_solid(x, y, z-1);
    case south: return is_solid(x, y, z+1);
  }
}

findLocationInSquare (x, y, z, distance, filled) {
  //If our distance is 0, just check this space.
  if (distance == 0) {
    if(validLocation(x, y, z)) return [x, y, z];
    else return null;
  }
  //If we selected to fill in the square, search the smaller square first.
  if (filled) {
    location = findLocationInSquare (x, y, z, distance-1, true);
    if (location != null) return location;
  }
  //Search in a square around the center.
  //Tends to favour closer locations without being too complicated.
  for (i = -distance + 1; i <= distance; i ++) {
    if (validLocation(x+i, y, z-distance)) return [x, y, z-distance];
    if (validLocation(x+distance, y, z+i)) return [x+distance, y, z];
    if (validLocation(x-i, y, z+distance)) return [x, y, z+distance];
    if (validLocation(x-distance, y, z-i)) return [x-distance, y, z];
  }
  return null;
}

findLocationInCube (x, y, z, distance) {
  //Search a cube around the center point.
  //Favour locations at a closer y, with a slight preference to being higher.
  for (i = 0; i <=distance; i ++) {
    location = findLocationInSquare (x, y+distance, z, distance, (i == distance));
    if (location != null) return location;
    if (i == 0) continue;
    location = findLocationInSquare (x, y-distance, z, distance, (i == distance));
    if (location != null) return location;
  }
  return null;
}

findLocation (x, y, z) {
  if (validLocation(x, y, z)) return [x, y, z];
  for (size = 1; size < 4; size ++) {
    location = findLocationInCube (x, y, z, size);
    if (location != null) return location;
  }
  return null;
}

recreateChest (x, y, z, facing) {
  if (!is_chest(x, y, z)) {
    if (findLocation(x, y, z) != null) {
      while (facesSolid(x, y, z, facing)) {
        facing = random(east, west, north, south);
      }
      placeChest(x, y, z, facing);
      //Update chest timer location.
    } else {
      //Remove chest timer.
    }
  }
}

theres one thing i don't understand about the new system, what happens when we really raid the dungeon? u can make stone bricks and the others (cracked and with plants) but its easier to mine the whole dungeon. then new players get a floating chest somewhere?

i think this system is better used in the frontier and not the wastelands, b/c waste resets every time anyway. didnt got the loot the 1st time then u will the 2nd time or 3rd time.

same with end: what if players mine the whole boat or tower 2 get the purpur? floating chest which is really hard 2 find then. so then u still better off waiting for next reset.

Needs to be implemented.

Very good point, very good argumentation, very good alternative supplied. Very good overall.
Thanks for your input!

I personally destroy the chest for my style of play. I love having extra chest that I don't have to craft later. I believe the wastelands chest should be the ones you cannot destroy as building there is quite useless. I don't want dungeon chest to stay in my frontier dig outs because I may need to build a massive farm where it stands.

Only valid locations are chosen. It will not respawn floating in the air.

Isnt this what players do in vanilla?

Aikar would implement the same player or a relative player to that player would not respawn items in chest

The chest and loot only appear for new players only. If an existing player enters the area, the chest will not appear. If they try to open a chest which appeared because a new player entered the area, it will be empty.

Huh? Two things:
One: what's the difference with the system that's currently in place? (you can't break chests, but items in chests get refilled every 3-7 days) It could happen there just as well.
Two: Aikar has implemented a system to check whether the person loading the chest is related to the person who emptied the chest before.

The chest appears if a new player enters the chunk after a 3-7 day time.

I don't really see a problem with the system as it is. Sure you like to break chests and now you will find you have to actually open them. That seems a small inconvenience for the problem that the new looting system solves. As far as mob grinders in the waste, just don't do it? the frontier is there and there are many public grinders in the frontier. A+ for the thought put into this but I personally would rather the chests stay there and not pop up later in a mob grinder. this way at least that player knows the chest is there and it doesn't just magically appear later. As far as breaking the chest to collect the loot, I don't do that myself unless it is in my outpost in which case more often than not im going to break the spawner too. Just seems mean to leave a chest there for someone to get excited about lol. in the waste the way it is set up they could actually find loot though.

I like this idea. It would be even better if it can check (I know Aikar has an algorithm for this but I don't know it) to make sure the 'new' chest location is naturally spawned and not player made, so that a chest does not appear on what is meant to be a spawning space for a mob in the grinder scenario.

I always feel that things should be left as close to vanilla as possible in the waste and wild. The only exception is when the vanilla rules cause large issues such as not being able to lock chests or protect your builds, or new features like custom mobs that only add to the experience. In this case, I see that there is no reason to block breaking the chests as they can just be respawned later.

I agree that mob grinders are better in the frontier, and EMC is play-your-way, so even if you don't agree with someone else's play style it's important that it still work. As long as someone's play style doesn't break any of the EMC rules it should be fully supported.

You bring up a good point about the chest in the mob grinder, however this happens a week later and a chest appearing in a mob grinder wont affect it functionally other than potentially blocking one spawn point if you make the spawn area the minimum height. Most players who would want to build in the waste are building temporary creations. They have long since abandoned a creation after a week. If the player is still using it, and notices the chest, they just break it. Having a chest that you can't break in the middle of your creation, is to my mind a much bigger frustration. You have to involve staff and ask them to come out and break one little chest for you, which you can still do if this chest respawning bothers you, but you no longer have to do just to build your thing.

To help understand my idea, here's a comparison between the present system (in red) and my proposed system (in green). This isn't just dungeons we are talking about. Chests are presently naturally generated in dungeons, strongholds, jungle temples, desert temples, nether fortresses, villages, end cities, end ships and igloos.

Looting And Exploring New Location
Currently: Cannot break chests. Have to manually open them and take the items out.
Proposed Solution: Players can break chests to loot them, a lot faster and more fun!

Returning To Same Location 1 Day Later
Currently: Come back to the same place and cannot remember which chests were broken or not. End up searching the same chests you've already opened to find nothing.
Proposed Solution: No new chests have appeared. Don't waste any time revisiting chests you've already opened. End up finding an extra chest you missed the first time!

Returning To Same Location 1 Week Later
Currently: End up searching the same chest again just in case. Again, disappointment.
Proposed Solution: Unless a new player has also visited the dungeon in the meantime and opted not to break any chests, the dungeon is the exact same. If they have, it's no worse.

New Player Coming To Explored Location 1 Day Later
Currently: Chests are intact and empty. The new player wastes their time checking a bunch of empty chests and gets nothing.
Proposed Solution: Chests can be destroyed, so they don't sit there empty with nothing in them.

New Player Coming To Explored Location 1 Week Later
Currently: Chests are intact and they can get loot.
Proposed Solution: Exactly the same, the chests will be in the same place with loot in them.

New Player Coming To Explored Location 1 Week Later If The Location Was Changed/Griefed
Currently: Random floating chests in the middle of the air.
Proposed Solution: Chests will appear in locations near where they were that make sense based on the algorithm.

Building a Mob Grinder In The Waste
Currently: You can awkwardly build around the floating chests or involve a staff member to manually remove them.
Proposed Solution: Build the mob grinder as you would normally.

Returning To Mob Grinder 1 Week Later
Currently: No issues, except the random chests in the middle if staff were not able to assist you or you didn't feel like wasting their time with a trivial chest breaking mission.
Proposed Solution: If a new player explored the same chunk, there is a chest to break. This will not functionally affect the mob grinder and not likely even be noticed. If it is noticed, it's broken in a fraction of a second. You could also ask a staff member to remove the chest permanently.

Building A Quarry In The Waste
Currently: You might find a chest in the area you decide to quarry. You get half way to bedrock, and realize there's chests in the quarry which you can't break. You dig out the rest of the quarry, and leave the floating chests in the air.
Proposed Solution: The chest can be broken without issue and you finish the quarry.

Returning To Same Quarry 1 Week Later
Currently: Floating chests remain. Another player probably build a cobble/dirt bridge to reach it.
Proposed Solution: No new chest is placed because there is no valid location to place it.

Building A Vertical Mine Shaft In The Waste
Currently: If you run into a chest on the way down, you need to shift the entire mineshaft over.
Proposed Solution: The chest can be broken without issue and you finish the mineshaft.

Returning To Vertical Mine Shaft 1 Week Later
Currently: Your mine shaft is unchanged.
Proposed Solution: Your mine shaft is unchanged. It's not a valid location to place a chest.